Skip to content

[Cookbook][External Parameters] Enhance content #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2014
Merged

[Cookbook][External Parameters] Enhance content #4269

merged 1 commit into from
Oct 15, 2014

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Sep 25, 2014

Enhance description of environment variables used as container parameters

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets -

@wouterj
Copy link
Member

wouterj commented Sep 25, 2014

He's back! 🍰

Even in debug mode, setting or changing an environment variable
requires your cache to be cleared to make the parameter available.
In debug mode, this is because only a parameter change within a
Symfony file triggers your configuration to be re-evaluated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reword this to something like:

In debug mode, this is required since only a change to a configuration file that is loaded by Symfony triggers your configuration to be re-evaluated.

@xabbuh
Copy link
Member

xabbuh commented Sep 25, 2014

@bicpi Great to see you again!

@bicpi
Copy link
Contributor Author

bicpi commented Sep 26, 2014

Thanks for the warm welcome! Hope to get some more things done soon.

@weaverryan
Copy link
Member

The comma looks good to me. Great additions Philipp!

@weaverryan weaverryan merged commit 93684e2 into symfony:2.3 Oct 15, 2014
weaverryan added a commit that referenced this pull request Oct 15, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][External Parameters] Enhance content

Enhance description of environment variables used as container parameters

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets | -

Commits
-------

93684e2 [Cookbook][External Parameters] Enhance description of environment variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants